Fix forwarded logic - #2219
Merged
Merged
Conversation
Signed-off-by: Troels Thomsen <troels@thomsen.io> Signed-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)
Partially reverts change adding support for X-Forwarded-Port. Changes the logic to prefer the standard Forwarded header over X-Forwarded headers. Prefer forwarded "host" over "for" since "for" represents the client and not the client's request. Signed-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)
This was referenced Mar 20, 2017
Collaborator
|
LGTM |
Contributor
|
LGTM |
1 similar comment
|
LGTM |
miminar
approved these changes
Mar 21, 2017
miminar
left a comment
miminar
left a comment
Contributor
There was a problem hiding this comment.
LGTM
The bug on our side has been fixed. Sorry for any inconvenience this might have caused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes all support for
X-Forwarded-Portin the URL builder. This header is not informative for determining the host given by the client. Updated the logic to always prefer the standardForwardedheader over the non-standardX-Forwarded-*headers when provided. Only use thehostparameter of theForwardedheader and never use theforparameter, which is incorrect for setting as the server host.Note the original reason for providing support for
X-Forwarded-Portwas related to a bug in a load balancer (see reference in #2008). Amazon ELB always setsX-Forwarded-Portregardless of whether the port is specified in theHostheader, and leaves the originalHostheader alone. The goal of the URL builder is to recreate the host exactly as given by the client, which this header is useless for.Carry #2214
Partially reverts #2008
Fixes #2177
Please review this so we can get a patch release for 2.6
Ping @tt @stevvooe @aaronlehmann @miminar @nwt @marcusmartins